OXDEV-8215: Raname a few variables; Remove unnecessary docblock or br…

…ackets;
OXID-eSales · Jul 29, 2024 · 6a8e5b4 · 6a8e5b4
1 parent 544d0f8
commit 6a8e5b4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/src/Module/Controller/ModuleListController.php b/src/Module/Controller/ModuleListController.php
@@ -25,7 +25,6 @@ public function __construct(
 
     /**
      * Query of Configuration Access Module
-     * @param ModuleFilters|null $filters
      * @return ModuleDataType[]
      */
     #[Query]

diff --git a/src/Module/DataType/ModuleDataTypeFactory.php b/src/Module/DataType/ModuleDataTypeFactory.php
@@ -23,16 +23,16 @@ public function createFromCoreModule(
         ModuleConfiguration $moduleConfig
     ): ModuleDataType {
         $titlesData = $moduleConfig->getTitle();
-        $title = $this->languageService->filterByLanguageAbbreviation(data: $titlesData);
+        $translatedTitle = $this->languageService->filterByLanguageAbbreviation(data: $titlesData);
 
-        $descriptionData = $moduleConfig->getDescription();
-        $description = $this->languageService->filterByLanguageAbbreviation(data: $descriptionData);
+        $description = $moduleConfig->getDescription();
+        $translatedDescription = $this->languageService->filterByLanguageAbbreviation(data: $description);
 
         return new ModuleDataType(
             id: $moduleConfig->getId(),
             version: $moduleConfig->getVersion(),
-            title: $title,
-            description: $description,
+            title: $translatedTitle,
+            description: $translatedDescription,
             thumbnail: $moduleConfig->getThumbnail(),
             author: $moduleConfig->getAuthor(),
             url: $moduleConfig->getUrl(),

diff --git a/src/Module/Exception/ModulesNotFoundException.php b/src/Module/Exception/ModulesNotFoundException.php
@@ -15,6 +15,6 @@ final class ModulesNotFoundException extends NotFound
 {
     public function __construct()
     {
-        parent::__construct(('Modules was not found.'));
+        parent::__construct('Modules was not found.');
     }
 }
diff --git a/src/Shared/Service/LanguageService.php b/src/Shared/Service/LanguageService.php
@@ -14,14 +14,14 @@
 class LanguageService implements LanguageServiceInterface
 {
     public function __construct(
-        private LanguageWrapperInterface $language
+        private LanguageWrapperInterface $languageWrapper
     ) {
     }
 
     public function filterByLanguageAbbreviation(array $data): ?string
     {
-        $langId = $this->language->getBaseLanguage();
-        $languageAbbr = $this->language->getLanguageAbbr(langId: $langId);
+        $langId = $this->languageWrapper->getBaseLanguage();
+        $languageAbbr = $this->languageWrapper->getLanguageAbbr(langId: $langId);
 
         if (isset($data[$languageAbbr])) {
             return $data[$languageAbbr];