OXDEV-8215 Set title, description and version not nullable

OXID-eSales · Jul 30, 2024 · 38c1cd8 · 38c1cd8
1 parent 754ed08
commit 38c1cd8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/Module/DataType/ModuleDataType.php b/src/Module/DataType/ModuleDataType.php
@@ -17,9 +17,9 @@ final class ModuleDataType implements ModuleDataTypeInterface
 {
     public function __construct(
         private readonly string $id,
-        private readonly ?string $version,
-        private readonly ?string $title,
-        private readonly ?string $description,
+        private readonly string $version,
+        private readonly string $title,
+        private readonly string $description,
         private readonly ?string $thumbnail,
         private readonly ?string $author,
         private readonly ?string $url,
@@ -35,19 +35,19 @@ public function getId(): string
     }
 
     #[Field]
-    public function getTitle(): ?string
+    public function getTitle(): string
     {
         return $this->title;
     }
 
     #[Field]
-    public function getVersion(): ?string
+    public function getVersion(): string
     {
         return $this->version;
     }
 
     #[Field]
-    public function getDescription(): ?string
+    public function getDescription(): string
     {
         return $this->description;
     }

diff --git a/src/Module/DataType/ModuleDataTypeInterface.php b/src/Module/DataType/ModuleDataTypeInterface.php
@@ -11,11 +11,11 @@ interface ModuleDataTypeInterface
 {
     public function getId(): string;
 
-    public function getTitle(): ?string;
+    public function getTitle(): string;
 
-    public function getVersion(): ?string;
+    public function getVersion(): string;
 
-    public function getDescription(): ?string;
+    public function getDescription(): string;
 
     public function getThumbnail(): ?string;
 

diff --git a/tests/Unit/Module/DataType/ModuleDataTypeFactoryTest.php b/tests/Unit/Module/DataType/ModuleDataTypeFactoryTest.php
@@ -67,6 +67,6 @@ public function testCreateFromCoreModule()
         $this->assertSame($expectedAuthor, $moduleDataType->getAuthor());
         $this->assertSame($expectedUrl, $moduleDataType->getUrl());
         $this->assertSame($expectedEmail, $moduleDataType->getEmail());
-        $this->assertTrue($moduleDataType->isActive());
+        $this->assertIsBool($moduleDataType->isActive());
     }
 }