Skip to content

Commit

Permalink
OXDEV-8215: Remove nullable from ModuleDataType properties
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcelOxid committed Aug 8, 2024
1 parent bcc30d1 commit 0bd3194
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
16 changes: 8 additions & 8 deletions src/Module/DataType/ModuleDataType.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,35 +25,35 @@ public function __construct(
string $version,
string $description,
bool $active,
private readonly ?string $thumbnail,
private readonly ?string $author,
private readonly ?string $url,
private readonly ?string $email,
private readonly string $thumbnail,
private readonly string $author,
private readonly string $url,
private readonly string $email,
private readonly string $lang
) {
parent::__construct($id, $title, $version, $description, $active);
}

#[Field]
public function getThumbnail(): ?string
public function getThumbnail(): string
{
return $this->thumbnail;
}

#[Field]
public function getAuthor(): ?string
public function getAuthor(): string
{
return $this->author;
}

#[Field]
public function getUrl(): ?string
public function getUrl(): string
{
return $this->url;
}

#[Field]
public function getEmail(): ?string
public function getEmail(): string
{
return $this->email;
}
Expand Down
8 changes: 4 additions & 4 deletions src/Module/DataType/ModuleDataTypeInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@
interface ModuleDataTypeInterface extends ComponentDataTypeInterface
{
#[Field]
public function getThumbnail(): ?string;
public function getThumbnail(): string;

#[Field]
public function getAuthor(): ?string;
public function getAuthor(): string;

#[Field]
public function getUrl(): ?string;
public function getUrl(): string;

#[Field]
public function getEmail(): ?string;
public function getEmail(): string;

#[Field]
public function getLang(): string;
Expand Down

0 comments on commit 0bd3194

Please sign in to comment.