OXDEV-7557 Fix phpcs reported issues

Signed-off-by: Anton Fedurtsya <[email protected]>
OXID-eSales · Nov 14, 2023 · 0aa210a · 0aa210a
1 parent f1a3a3b
commit 0aa210a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/tests/Unit/Infrastructure/ChangeThemeSettingRepositoryTest.php b/tests/Unit/Infrastructure/ChangeThemeSettingRepositoryTest.php
@@ -36,7 +36,7 @@ public function testChangeThemeSettingInteger(): void
             ->method('saveSettingValue')
             ->with($nameID, 'awesomeTheme', '123');
 
-        $repository->saveIntegerSetting($nameID, 123,  'awesomeTheme');
+        $repository->saveIntegerSetting($nameID, 123, 'awesomeTheme');
     }
 
     public function testChangeNoThemeSettingInteger(): void
@@ -64,6 +64,6 @@ public function testChangeNoThemeSettingInteger(): void
         $this->expectException(NotFound::class);
         $this->expectExceptionMessage('The integer setting "' . $nameID->val() . '" doesn\'t exist');
 
-        $repository->saveIntegerSetting($nameID, 123,  'awesomeTheme');
+        $repository->saveIntegerSetting($nameID, 123, 'awesomeTheme');
     }
 }
diff --git a/tests/Unit/Infrastructure/ShopSettingRepositoryTest.php b/tests/Unit/Infrastructure/ShopSettingRepositoryTest.php
@@ -264,14 +264,9 @@ private function getFetchOneShopSettingRepoInstance(string|bool $qbReturnValue):
         return $this->getShopSettingRepository($queryBuilderFactory);
     }
 
-    /**
-     * @param MockObject|QueryBuilderFactoryInterface $queryBuilderFactory
-     * @return ShopSettingRepository
-     */
     private function getShopSettingRepository(
-        MockObject|QueryBuilderFactoryInterface $queryBuilderFactory
-    ): ShopSettingRepository
-    {
+        QueryBuilderFactoryInterface $queryBuilderFactory
+    ): ShopSettingRepository {
         $basicContextMock = $this->getBasicContextMock(1);
         $eventDispatcher = $this->createMock(EventDispatcherInterface::class);
         $shopSettingEncoder = new ShopSettingEncoder();

diff --git a/tests/Unit/Service/ThemeSettingServiceTest.php b/tests/Unit/Service/ThemeSettingServiceTest.php
@@ -314,14 +314,13 @@ public function testChangeThemeSettingCollection(): void
         $this->assertSame($value, $collectionSetting->getValue());
     }
 
-    public function getSut(
+    private function getSut(
         ?ThemeSettingRepositoryInterface $themeSettingRepository = null,
         ?JsonServiceInterface $jsonService = null,
     ): ThemeSettingService {
+        $themeSettingRepository = $themeSettingRepository ?? $this->createStub(ThemeSettingRepositoryInterface::class);
         return new ThemeSettingService(
-            themeSettingRepository: $themeSettingRepository ?? $this->createStub(
-            ThemeSettingRepositoryInterface::class
-        ),
+            themeSettingRepository: $themeSettingRepository,
             jsonService: $jsonService ?? $this->createStub(JsonServiceInterface::class)
         );
     }