Skip to content

Simplify regex to reduce Sonar complexity while preserving behavior #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PawanMohit16 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify regex to reduce Sonar complexity while preserving behavior #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions backend/apps/owasp/models/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from __future__ import annotations

import itertools
import logging
import re
from urllib.parse import urlparse
Expand Down Expand Up @@ -198,17 +197,23 @@ def get_leaders(self):

leaders = []
for line in content.split("\n"):
leaders.extend(
[
name
for name in itertools.chain(
*re.findall(
r"[-*]\s*\[\s*([^(]+?)\s*(?:\([^)]*\))?\]|\*\s*([\w\s]+)", line.strip()
)
)
if name.strip()
]
stripped_line = line.strip()
names = []

bracketed_pattern = (
r"[-*]\s{0,3}\[\s{0,3}([^\]\(]{1,200})"
r"(?:\s{0,3}\([^)]{0,100}\))?\s{0,3}\]"
)
names.extend(re.findall(bracketed_pattern, stripped_line))
names.extend(re.findall(r"\*\s{0,3}([\w\s]{1,200})", stripped_line))

cleaned_names = []
for raw_name in names:
if raw_name.strip():
cleaned = re.sub(r"\s{0,3}\([^)]{0,100}\)\s{0,3}$", "", raw_name).strip()
cleaned_names.append(cleaned)

leaders.extend(cleaned_names)

return leaders

Expand Down