Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deployment workflow #749

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

jake-low
Copy link
Contributor

@jake-low jake-low commented Oct 1, 2024

This PR aims to simplify both development and deploy workflows by making the frontend app easier to run and reducing the differences between what runs in local dev and what gets deployed.

Notable changes:

  • PUBLIC_URL has been removed; the frontend is now agnostic to where it gets deployed (meaning it uses domain-less URLS like /static/js/main.12a34bc.js to fetch required resources). This means you can build one artifact and deploy it anywhere, rather than needing a different artifact for each server you're deploying to (including localhost).
  • The Docker image now includes a default nginx.conf file. This file is suitable for production use (though it's HTTP, so it should be used along with a TLS-terminating reverse proxy). In a future PR I'll update the Helm charts in the deploy repo to remove the nginx config file that's inlined there, and use this one instead.
  • Cleaned up a bunch of old scripts and snippets that were only used when the frontend used to be served from Github Pages.

The changes here go along with some changes to the Django app configuration here: OSMCha/osmcha-django#719

Copy link
Collaborator

@willemarcel willemarcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, @jake-low! It's working well

@jake-low
Copy link
Contributor Author

No worries, thanks for the review! I'm going to hold off on merging this until OSMCha/osmcha-django#719 is also approved. After that I'll work on the required changes to osmcha-deploy as mentioned in that PR.

I encountered this error when building in minikube on macOS, but not
when building with an ordinary docker build. Root cause unclear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants