-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deployment workflow #749
Open
jake-low
wants to merge
9
commits into
master
Choose a base branch
from
jlow/deployment-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemarcel
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, @jake-low! It's working well
No worries, thanks for the review! I'm going to hold off on merging this until OSMCha/osmcha-django#719 is also approved. After that I'll work on the required changes to |
I encountered this error when building in minikube on macOS, but not when building with an ordinary docker build. Root cause unclear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify both development and deploy workflows by making the frontend app easier to run and reducing the differences between what runs in local dev and what gets deployed.
Notable changes:
PUBLIC_URL
has been removed; the frontend is now agnostic to where it gets deployed (meaning it uses domain-less URLS like/static/js/main.12a34bc.js
to fetch required resources). This means you can build one artifact and deploy it anywhere, rather than needing a different artifact for each server you're deploying to (including localhost).nginx.conf
file. This file is suitable for production use (though it's HTTP, so it should be used along with a TLS-terminating reverse proxy). In a future PR I'll update the Helm charts in the deploy repo to remove the nginx config file that's inlined there, and use this one instead.The changes here go along with some changes to the Django app configuration here: OSMCha/osmcha-django#719