Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of obsolete CPL_CVSID() macro #50

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 4, 2024

This macro dates back to CVS time and would only make sense if we substituted the $Id$, which we don't do.
We also plan to remove the macro from GDAL's cpl_port.h header in OSGeo/gdal#11433 , so let's remove use of it by its only known external user :-)

This macro dates back to CVS time and would only make sense if we
substituted the $Id$, which we don't do.
We also plan to remove the macro from GDAL's cpl_port.h header in
OSGeo/gdal#11433 , so let's remove use
of it by its only known external user :-)
@tbonfort
Copy link
Member

tbonfort commented Dec 4, 2024

But what if we ever want to switch back to CVS? 🦕 😜

@neteler neteler added this to the 1.0.3 milestone Dec 4, 2024
@schwehr
Copy link
Member

schwehr commented Dec 4, 2024

Thanks @rouault ! +1 for this PR.

@neteler neteler merged commit b9c4ed1 into OSGeo:main Dec 5, 2024
1 check passed
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants