Skip to content

Conversation

@bith3ad
Copy link

@bith3ad bith3ad commented Nov 10, 2025

Hi,

with the following a few helpers are added to OP-TEE dt lib and some improvements are made:

  • patch-1: fixes the reserved-memory handling in case a of-overlay fragment should be added by OP-TEE
  • patch-2/3: Add a helper to write of-overlays targeting a specific node
  • patch-4: Add the support to write a of overlay fragment to set the secure-state which is required for the BL33 if to collect all changes done by OP-TEE.

@bith3ad
Copy link
Author

bith3ad commented Nov 10, 2025

Fixed stub compile issues

@github-actions
Copy link

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Dec 18, 2025
@bith3ad
Copy link
Author

bith3ad commented Dec 22, 2025

FYI: I will fix the commit message subject:
core: dt: add add_dt_node_overlay_fragmet helper

to: core: dt: add add_dt_node_overlay_fragment helper once I squash and rebase my commits.

@github-actions github-actions bot removed the Stale label Dec 23, 2025
@OP-TEE OP-TEE deleted a comment from jenswi-hacs Jan 7, 2026
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bith3ad, @jenswi-linaro, would be be okay to have the fixup commits squashed?

@jenswi-linaro
Copy link
Contributor

@bith3ad, @jenswi-linaro, would be be okay to have the fixup commits squashed?

Yes, please

@bith3ad bith3ad force-pushed the topic/dt-improvements branch from 39a2ca8 to 1058745 Compare January 11, 2026 14:28
@bith3ad
Copy link
Author

bith3ad commented Jan 11, 2026

  • rebased to 4.9.0-rc1
  • squashed !fixup commits
  • addressed 256 byte stack allocation
  • fixed commit message spelling

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Etienne Carriere <[email protected]> with a minor comment.

@bith3ad
Copy link
Author

bith3ad commented Jan 12, 2026

Reviewed-by: Etienne Carriere <[email protected]> with a minor comment.

@etienne-lms The review is for the whole series or only for a particular patch?

Also since I'm not to familiar with the OP-TEE dev-flow. I need to add the r-b tag and do a force-push?

@etienne-lms
Copy link
Contributor

Sorry, I was not explicit. My R-b tag stands for the whole series.
Yes you would need to update the whole series adding the review tag in each commit message.
If other review tags are posted, you would be to update again accordingly.

Marco Felsch added 4 commits January 12, 2026 12:38
Currently add_res_mem_dt_node() doesn't add a overlay fragment if
CFG_EXTERNAL_DTB_OVERLAY=y and the provided DTB already contains a
"/reserved-memory" e.g. due to some co-processor reserved-memory
descriptions.

To fix this add_res_mem_dt_node() must always add a "/reserved-memory"
DTB overlay fragment if a DTB overlay shall be created
(_CFG_USE_DTB_OVERLAY=y).

Reviewed-by: Etienne Carriere <[email protected]>
Signed-off-by: Marco Felsch <[email protected]>
Exentend the API to be able to specify the DTB overlay "target-path".

Reviewed-by: Etienne Carriere <[email protected]>
Signed-off-by: Marco Felsch <[email protected]>
Add a helper to add overlays to an external-dt for a caller provided
node. The overlay can be used by the caller to overwrite node
properties. The subsequent BL33 can use the overlay to apply the changes
to the BL33 DTB and kernel DTB.

Reviewed-by: Etienne Carriere <[email protected]>
Signed-off-by: Marco Felsch <[email protected]>
Add support to write the "secure-status" property to overlays in
addition to the inline DTB changes if the user enabled the overlay
support.

Most BL33 firmwares don't reuse the DTB provided to OP-TEE. Therefore
add an overlay for the requested node to not lose the changes done by
OP-TEE. The overlay can be used by the BL33 firmware to apply the
changes.

Reviewed-by: Etienne Carriere <[email protected]>
Signed-off-by: Marco Felsch <[email protected]>
@bith3ad bith3ad force-pushed the topic/dt-improvements branch from 1058745 to 1491648 Compare January 12, 2026 11:42
@bith3ad
Copy link
Author

bith3ad commented Jan 12, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants