Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating codebase to produce selective editing outputs #160

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

updating codebase to produce selective editing outputs #160

wants to merge 5 commits into from

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Jan 28, 2025 •
edited
Loading

Pull Request Title

Summary

Made a number of changes to code base to create selective editing out:

  • impute.py: Added spp to idbr mapping for back data, needed for SE outputs as we map on idbr formtype and imputation class
  • impute.py: Used f string to call target directly from config instead of assigning target variable
  • pivot_imputation_value.py: Added config as kwarg argument in create_imputation_link_output
  • produce_additional arguments.py: Added imputation class to required columns for additional outputs
  • selective_editing_contributor_output.py: Correctly filter input data for SE contributor file
  • selective_editing_contributor_output.py: Dropping columns not needed in SE outputs
  • selective_editing_question_output.py Merging on period for SE outputs, renaming to required column names
  • selective_editing.py: Removed converting to data time
  • back_data.py: formatting idbr formtype, converting back to idbr from spp formtype. copying cellno to cell number
  • test_main now removes created config after running
  • test_selective_editing: removing converting column to datetime object
  • test_back_data: copied over cell_no into cellnumber, updated order of columns, converted type of expected output to match output

Add your summary here - keep it brief, to the point, and in plain English.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Checklists

This pull request meets the following requirements:

Creator Checklist

  • Installable with all dependencies recorded
  • Runs without error
  • Follows PEP8 and project-specific conventions
  • Appropriate use of comments, for example, no descriptive comments
  • Functions documented using Numpy style docstrings
  • Assumptions and decisions log considered and updated if appropriate
  • Unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • Other forms of testing such as end-to-end and user-interface testing have been considered and updated as required

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Reviewer Checklist

  • Test suite passes (locally as a minimum)
  • Peer reviewed with review recorded

Additional Information

Please provide any additional information or context that would help the reviewer understand the changes in this pull request.

Related Issues

Link any related issues or pull requests here.

@Jday7879
Changes:
0599f40 
 - impute.py: Added spp to idbr mapping for back data, needed for SE outputs as we map on idbr formtype and imputation class
 - impute.py: Used f string to call target directly from config instead of assigning target variable
 - pivot_imputation_value.py: Added config as kwarg argument in create_imputation_link_output
 - produce_additional arguments.py: Added imputation class to required columns for additional outputs
 - selective_editing_contributor_output.py: Correctly filter input data for SE contributor file
 - selective_editing_contributor_output.py: Dropping columns not needed in SE outputs
 - selective_editing_question_output.py Merging on period for SE outputs, renaming to required column names
 - selective_editing.py: Removed converting to data time
 - back_data.py: formatting idbr formtype, converting back to idbr from spp formtype. copying cellno to cell number
 - test_main now removes created config after running
 - test_selective_editing: removing converting column to datetime object
 - test_back_data: copied over cell_no into cellnumber, updated order of columns, converted type of expected output to match output
@Jday7879 Jday7879 marked this pull request as ready for review January 28, 2025 15:52
@Jday7879 Jday7879 requested a review from ldavies99 February 6, 2025 15:28
ldavies99
ldavies99 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@ldavies99 ldavies99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and the unit tests pass, so happy for this to be merged in. The summary description of the changes were very useful except for one file not having any description of changes (commented below).

mbs_results/staging/stage_dataframe.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No description for changes in this file in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldavies99 ldavies99 ldavies99 approved these changes

@robertswh robertswh Awaiting requested review from robertswh robertswh is a code owner

@giuliag92 giuliag92 Awaiting requested review from giuliag92 giuliag92 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jday7879 @ldavies99