Move accessibility outside main element #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enhance accessibility it was suggest in a recent DAC audit to move the breadcrumb above the `<main>` element. This turned out to be harder than I first thought as +layout.svelte don't allow named slots. Following a [reddit thread](https://www.reddit.com/r/sveltejs/comments/12vf9m4/passing_correct_slots_to_component_slot_from_a/), I found the [solution proposed by Rich Harris](sveltejs/kit#627 (comment)) which is the one implemented here. Fixed a typo as well, "indictator -> indicator"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance accessibility it was suggest in a recent DAC audit to move the breadcrumb above the
<main>element. This turned out to be harder than I first thought as +layout.svelte don't allow named slots.Following a reddit thread, I found the solution proposed by Rich Harris which is the one implemented here.
Fixed a typo as well, "indictator -> indicator"