Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design system to 72.2.0 #84

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

helenb
Copy link
Contributor

@helenb helenb commented Jan 22, 2025

What is the context of this PR?

https://jira.ons.gov.uk/browse/CMS-305

This updates the design system to the latest version. Incorporating the new hero components will be handled by separate tickets.

How to review

Follow-up Actions

Create tickets for integrating the new hero components from the design system.

@helenb helenb requested a review from a team as a code owner January 22, 2025 14:42
Copy link
Contributor

@nehakerung nehakerung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as review guide states

Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled it down, tested it locally. Working as expected =)

@zerolab
Copy link
Contributor

zerolab commented Jan 23, 2025

The only breakage I could find is the header on statistical articles is broken and that will likely be highlighted in testing

Screenshot 2025-01-23 at 09 36 10

@zerolab
Copy link
Contributor

zerolab commented Jan 23, 2025

The only breakage I could find is the header on statistical articles is broken and that will likely be highlighted in testing

PEBCAK. Missed npm run build. all good

@helenb helenb merged commit 0f58714 into main Jan 23, 2025
9 checks passed
@helenb helenb deleted the feature/update-design-system-CMS-305 branch January 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants