Increase search button height on small screens #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #3457 ONSDESYS-233
The button height is set by the height of the text in the button so when the button has only an icon the button is smaller. I have added a margin top and bottom to the icon to stop the shrinking of the button. To do this I have flipped the logic for the margin right so that the margin right is always set and then is overridden and set to 0 on smaller screens.
How to review this PR
Use the
example-header-external-with-navigation-and-searchexample and see that onmainthe search button is smaller than the menu button when you reduce the window width to > 500px. See that on this branch that in the same situation the button is now the same height.Checklist
This needs to be completed by the person raising the PR.