Add Menu button in new header variant #3478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SriHV
changed the title
Im not sure if the focus state should look like this, usually our focus states have black underlines. This will need to be checked with a designer |
The links in the menu look like this when focused |
When open and focused on, the menu button looks like this, I know its like this in the prototype but I think this may need to be reviewed by a designer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-159
Added Menu button in the new header variant "basic". The Menu will have Top section and new Lower section
Topic section will have up to 3 columns. Each column have a header and under it can contain hyperlinks
Lower section will have also have 3 columns and subsequent child items.
The spacing for now is similar to the items in footer component.
Introduced new button variant for the menu button and also followed tech notes left in the ticket
The example is taken from here
Code is similar to the one available here
How to review this PR
Check that example-header-basic has the new menu button and has the design as specified in figma and the prototype
Checklist
This needs to be completed by the person raising the PR.