-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ONS logo alt text #3075
Update ONS logo alt text #3075
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the DAC issue I don't think this addresses the ask. The word logo hasn't been removed from the alt text but has been removed from the class name which seems to have broken the logo link focus state. I think the alt text should be something a bit more succinct like "Office for National Statistics homepage". We will also need the Welsh translation for this too.
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As richard's said maybe Hafan needs to be capitalised. Apart from that it looks good now. Rather than having just "Office for National Statistics homepage" in the title of the svg maybe we can say this : "Link to Office for National Statistics homepage" ?
I think it should just be "Office for National Statistics homepage" according to the research I have done. https://www.w3.org/TR/WCAG20-TECHS/H30.html example 2 on this page is an example of our use case here I think the Welsh translation I provided on this PR still does need to be properly checked though |
What is the context of this PR?
Fixes https://github.com/ONSdigital/ons-service-manual-website/issues/385
Updated the alt text for the ons logo image link to provide a more accurate description of its content or purpose. Additionally, assigned the role of 'image' to the SVG
How to review this PR
Check that
Checklist
This needs to be completed by the person raising the PR.