Fix/3004/icon in footer not clickable #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balibirchlee
requested review from
rmccar,
adi-unni,
precious-onyenaucheya-ons and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
reviewed
Feb 6, 2024
alessioventuriniAND
approved these changes
Feb 6, 2024
|
Have you pushed your latest changes? I cant see any extra commits since I last looked |
alessioventuriniAND
approved these changes
Feb 29, 2024
SriHV
approved these changes
Mar 1, 2024
rmccar
pushed a commit
that referenced
this pull request
Mar 6, 2024
alessioventuriniAND
added a commit
that referenced
this pull request
Apr 4, 2024
…wcag 22 level aaa (#3119) * ⬆️ Back To Top Link ⬆️ (#2990) * Page template for length * Add macro * Add component foundations * Build stylesheet * Add additional functionality * Improved functionality * Fix border and layout * Fix resize behaviour * Changes to CSS * Add more tests * Update VR Tests * Change to full width --------- Co-authored-by: Alessio Venturini <[email protected]> * Description list not structured properly for screen readers (#3053) * initial change * update test * update test * update comment * update comment * Update placeholder text colour (#3062) * Fix/3004/icon in footer not clickable (#3036) * Fix checkbox appearance on safari (#3066) * Adding the change in readme (#3067) * updated youtube video to a more accessible one * updated reference files --------- Co-authored-by: Aditya Unnithan_ONS <[email protected]> Co-authored-by: Precious Onyenaucheya <[email protected]> Co-authored-by: rmccar <[email protected]> Co-authored-by: Bali Birch-Lee_ONS <[email protected]> Co-authored-by: SriHV <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
As the custom poweredBy accepts HTML and the IDS website is using this to render a more complicated set up than a simple icon image - it has been agreed that IDS would instead add the links to their existing html. Any other implementation would result in a breaking change, requiring either IDS to simplify their existing footer (i.e. providing only an image) or us to scope an enhancement to the current footer modelled after IDS's current set up.
Whether ourselves or IDS feel that this enhancement should be made is up for discussion, but is beyond the scope of this ticket.
As such, the ticket has been adjusted to focus on providing links for the existing default ONS icons which are responsive to the language selection (i.e. the Welsh language version which renders the Welsh variant of the default icon has a link to the Welsh site, and vice versa for the English language version).
fixes #3004
How to review this PR
Run locally and head to the footer component, checking example footer cymraeg for the Welsh language version and example footer default for the English language version.
Checklist
This needs to be completed by the person raising the PR.