Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onsCollapsible #2895

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Remove onsCollapsible #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebed07
remove onscollapsible
rmccar Nov 9, 2023
eeeaf6b
Merge branch 'main' into improvements/2868/onscollapsible-removal
rmccar Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/components/collapsible/_macro.njk
View file
Open in desktop

This file was deleted.

151 changes: 0 additions & 151 deletions src/components/collapsible/_macro.spec.js
View file
Open in desktop

This file was deleted.

13 changes: 3 additions & 10 deletions src/components/details/_macro.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ describe('macro: details', () => {
it('has provided title text', () => {
const $ = cheerio.load(renderComponent('details', EXAMPLE_DETAILS_BASIC));

const titleText = $('.ons-details__title')
.first()
.text()
.trim();
const titleText = $('.ons-details__title').first().text().trim();
expect(titleText).toBe('Title for details');
});

Expand All @@ -62,9 +59,7 @@ describe('macro: details', () => {
it('has provided content text', () => {
const $ = cheerio.load(renderComponent('details', EXAMPLE_DETAILS_BASIC));

const titleText = $('.ons-details__content')
.text()
.trim();
const titleText = $('.ons-details__content').text().trim();
expect(titleText).toEqual(expect.stringContaining('Content for details'));
});

Expand Down Expand Up @@ -143,9 +138,7 @@ describe('macro: details', () => {
it('calls with content', () => {
const $ = cheerio.load(renderComponent('details', { EXAMPLE_DETAILS_BASIC }, 'Example content...'));

const content = $('.ons-details__content')
.text()
.trim();
const content = $('.ons-details__content').text().trim();
expect(content).toEqual(expect.stringContaining('Example content...'));
});
});