fix: prevent breadcrumbs overflow on mobile with horizontal scroll #4509
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add overflowX: 'auto' to Breadcrumbs container for horizontal scroll on narrow screens - Set minWidth: '120px' for the last breadcrumb item to ensure readable truncation Fixes ONEARMY#4508
github-project-automation
bot
added this to
Community Platform and Core Team - BAU list
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4509
|
| Run status |
|
| Run duration | 11m 31s |
| Commit |
|
| Committer | Mário Nunes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
88
|
| View all changes introduced in this branch ↗︎ | |
dalibormrska
added
the
Review allow-preview ✅
Member
|
Wow @manojalluri, really quick response, thank you for that!
|
Contributor
|
heey @manojalluri, just checking in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the breadcrumbs overflow issue on mobile devices by adding horizontal scroll support to the Breadcrumbs component.
Changes Made
overflowX: 'auto'to the Breadcrumbs Flex container to enable horizontal scrolling when content exceeds screen widthminWidth: '120px'for the last breadcrumb item to ensure readable truncation while maintaining a minimum visible widthFixes #4508
PR Checklist
What is the new behavior?
When breadcrumbs contain long titles on mobile devices, instead of causing the whole screen to scroll sideways, the breadcrumbs container now scrolls horizontally within itself. The last breadcrumb item maintains a minimum width of 120px for readability.
Does this PR introduce a breaking change?
No
Other information
This fix was suggested in the issue - truncating the last item with a minimum width and applying horizontal scroll to the container when the screen width is smaller than the component width.