Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source: support pcap-over-ip #12318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mmaatuq
Copy link
Contributor

@mmaatuq mmaatuq commented Dec 22, 2024

Ticket: #5499

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: #5499

Describe changes:

  • This is an initial version, and it currently follows a logic similar to Zeek Pluging: https://github.com/emnahum/zeek-pcapovertcp-plugin/tree/master
  • Supports only pcap format
  • I think this feature could be implemented as part of libpcap, I'm not sure though!
  • Sanity test was done using polar proxy
  • Could be tested with option -R socket_addr e.g. suricata/src/.libs/lt-suricata -c suricata.yaml -R 127.0.0.1:57012

Ticket: OISF#5499

- This is an initial version, and it currently follows a logic similar to
Zeek Pluging: https://github.com/emnahum/zeek-pcapovertcp-plugin/tree/master
- Supports only pcap format
- I think this feature could be implmented as part of libpcap, I'm not so
  sure though

Signed-off-by: mmaatuq <[email protected]>
@mmaatuq mmaatuq marked this pull request as draft December 22, 2024 19:16
@mmaatuq
Copy link
Contributor Author

mmaatuq commented Dec 22, 2024

I wanted to draft it due to :

  • Pipeline errors are expected.
  • Not documented
  • Not tests yet
  • I want an early feedback on this MR, as I'm not so comfortable with Suricata internals, but tried to follow same logic for other packet acquisition modules.
  • Docs here are empty.
  • the plan is to refactor and add missing tests/docs while addressing the comments on this MR

but changed it to make it visible for feedback.

@mmaatuq mmaatuq marked this pull request as ready for review December 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant