Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Added translation option for text 'segment' #4624

Merged

Conversation

nithin-trenser
Copy link
Contributor

@nithin-trenser nithin-trenser commented Dec 24, 2024

Context

A translation option for the term 'segment' has been incorporated by FlyWheel.io.

Changes & Results

The term 'segment' can be adapted to alternative terminology. The react i18n library facilitates this translation. It is used for the set segment labels in both segmentation and TMTV modes.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 10 with WSL.2
  • Node version: v18.20.4
  • Browser: Chrome 120.0.6099.71

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 596eccf
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/676a790640387000082d9b0a
😎 Deploy Preview https://deploy-preview-4624--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 596eccf
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/676a79060c37410008c690a2
😎 Deploy Preview https://deploy-preview-4624--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@IbrahimCSAE IbrahimCSAE merged commit 8606791 into OHIF:master Jan 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants