feat: group measurements by study #4617
Open
+53
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-service-filtering
…ts-service-filtering
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pedrokohler
changed the title
pedrokohler
changed the title
wayfarer3130
changed the base branch from
master
to
feat/measurements-service-filtering
…/Viewers into feat/measurements-service-filtering
| const oldValues = groupedMeasurements.get(key); | ||
| oldValues.push(item); | ||
| return groupedMeasurements; | ||
| }, new Map()) as Map<string, object[]>; |
There was a problem hiding this comment.
Cant you do new Map<string,object[]> to get the typing right?
| {Array.from(measurements).map(([key, value]) => { | ||
| return ( | ||
| <MeasurementTable | ||
| key={`tracked-${key}`} |
There was a problem hiding this comment.
This isn't necessarily tracked on this version of it, so you shouldn't be referencing tracked here, but should just get something passed in from the parent about what you are naming this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Building on top of: #4501
Changes & Results
These changes group the measurements of the all-measurements tab by study.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment