fix: Inconsistencies and update the style setting on load for embedded styles from codingValues #4599
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/style-for-multiple-findingSites
|
| Run status |
|
| Run duration | 02m 22s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
sedghi
reviewed
Dec 19, 2024
| @@ -23,28 +23,44 @@ const codingValues = { | |||
| 'SCT:69536005': { | |||
| text: 'Head', | |||
| type: 'site', | |||
| style: { | |||
| color: 'red', | |||
There was a problem hiding this comment.
Can we normalize this to RGB or hex instead of text? What shade of red are we referring to, and what is its brightness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the codingValues has a site/style value, and an SR is loaded containing annotations labelled with finding/findingSites values, there are inconsistencies with how the styling is applied, or whether it is applied at all.
This also occurred with styling applied in different orders.
Changes & Results
Added some extra styling for the test codingValues provided so that this can be seen.
Changed the updateMeasurement to apply the provided style first, but otherwise use the first style found from: finding, the first findingSite found.
Added support for multiple findingSites names. This allows differentiation between site data for different uses, but doesn't really deal well with multiple sites yet.
Testing
Draw some annotations in basic test mode
Right click annotations, and use the finding/site sub-menus to apply finding or site values.
Note how the new version is order independent - the finding style always takes precedence if there is one, while the previous version last change to be applied got done.
Save an SR
Load the SR again in basic mode
You should see the annotation styles being applied.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment