Ggr0921 #530
Open
Ggr0921 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimshitc
reviewed
Sep 13, 2021
| 'Stof' AS source_concept_class_id, | ||
| NULL AS standard_concept, | ||
| 'Ingredient' AS source_concept_class_id, | ||
| 'S' AS standard_concept, |
There was a problem hiding this comment.
looks suspicious - making source ingredient standard
dimshitc
requested changes
Sep 13, 2021
|
|
||
| LEFT JOIN SOURCES.GGR_SAM sam ON sam.mppcv = mpp.mppcv | ||
| WHERE OUC = 'C' | ||
| and sam.hyr_ not like 'LA%' |
GGR/auto_init.sql
Outdated
| * limitations under the License. | ||
| **************************************************************************/ | ||
| /* | ||
| SELECT devv5.FastRecreateSchema(); |
There was a problem hiding this comment.
this is not a part of load_stage or create input
GGR/auto_init.sql
Outdated
| /* | ||
| SELECT devv5.FastRecreateSchema(); | ||
| /**************************************************************************/ | ||
|
|
There was a problem hiding this comment.
the block is OK, should stay there.
also autors should be added, see how it's done in other vocabularies
| WHERE mpp.ouc = 'C';--OUC means *O*ne, m*U*ltiple or pa*C*k | ||
| LEFT JOIN SOURCES.GGR_SAM sam ON mpp.mppcv = sam.mppcv | ||
| WHERE mpp.ouc = 'C' | ||
| and mpp.hyr_ not like 'LA%';--OUC means *O*ne, m*U*ltiple or pa*C*k |
There was a problem hiding this comment.
what is this change? new condition? need comment
| ); | ||
| update |
There was a problem hiding this comment.
still don't know the convention(
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| **************************************************************************/ | ||
| /**************************************************************************/ |
There was a problem hiding this comment.
the header was fine, add the author and year, see in other vocabs how it's done in load_stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.