RxNorm Extension buider changes #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divakhnenko
requested review from
dimshitc,
hardhouse,
Alexdavv,
ekorchmar and
p-talapova
dimshitc
requested changes
Nov 21, 2020
| @@ -6408,7 +6408,7 @@ FROM maps_to m | |||
| JOIN ex e ON e.concept_id = m.to_id | |||
| JOIN r_to_c rtc ON rtc.concept_code_1 = m.from_code | |||
| JOIN concept dc ON dc.concept_id = rtc.concept_id_2 | |||
| WHERE dc.vocabulary_id IN ( | |||
| WHERE EXISTS ( | |||
There was a problem hiding this comment.
Ой. а разве так работает?
у тебя же внутри подзапроса должно быть условие, связывающее подзапрос с запросом
There was a problem hiding this comment.
Да, это работает. @ekorchmar посоветовал так сделать.
There was a problem hiding this comment.
а он случайно не объяснил, зачем нам подзапрос, который всегда дает true?
There was a problem hiding this comment.
WHERE dc.vocabulary_id = c_int.vocabulary_id
Добавила условие
Alexdavv
reviewed
Nov 23, 2020
| @@ -122,44 +122,7 @@ JOIN concept c ON c.concept_id = r.concept_id_2 | |||
| 'RxNorm', | |||
| 'RxNorm Extension', | |||
| 'UCUM' | |||
| ) | |||
|
|
|||
| UNION ALL | |||
There was a problem hiding this comment.
Once we made a mistake in one of the RxE releases there's no chance to fix it.
Anyway, when we populate relationship_to_concept we go through existing mappings and synomyms. So this step not only redundant but dangerous.
hardhouse
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues were found and fixed while creating the script for NCCD vocabulary