Additional rewrite rules for InterSystems IRIS #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff of the CSV file shows all lines have changed, probably because of different end-of-line indicators (carriage return?). Could you revise the PR so the diff shows only those lines that have changed? |
|
apologies, there seems to have been a disagreement between RStudio and VS Code, but it looks like they're now back to the expected LF line ending |
schuemie
approved these changes
Oct 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two additions to the initial dialect submission after preparation of our DataConnector PR and further review with @alex-odysseus
FROM ( VALUES ... )that is now correctedCOALESCE(DATEADD())combinations that would lead to unrecognized date formatting when running some cohorts and analyses.