Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cache size #90

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Reduce cache size #90

merged 5 commits into from
Oct 6, 2023

Conversation

lhjohn
Copy link
Collaborator

@lhjohn lhjohn commented Oct 6, 2023

Resolves issue #88.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ff9e22e) 99.59% compared to head (ad5b413) 99.59%.

❗ Current head ad5b413 differs from pull request most recent head 53af472. Consider uploading reports for the commit 53af472 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #90   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files            9        9           
  Lines          488      493    +5     
========================================
+ Hits           486      491    +5     
  Misses           2        2           
Files Coverage Δ
R/Estimator.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax egillax self-requested a review October 6, 2023 10:44
@egillax
Copy link
Collaborator

egillax commented Oct 6, 2023

Could you add a unit test for this?

Copy link
Collaborator

@egillax egillax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge.

@lhjohn
Copy link
Collaborator Author

lhjohn commented Oct 6, 2023

Resolves issue #88.

@lhjohn lhjohn closed this Oct 6, 2023
@lhjohn lhjohn reopened this Oct 6, 2023
@lhjohn lhjohn merged commit 1f50fa5 into develop Oct 6, 2023
13 checks passed
@egillax egillax deleted the 88-reduce-cache-size branch October 12, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants