fixes for module

OHDSI · Apr 30, 2024 · 7f668e7 · 7f668e7
1 parent cff3363
commit 7f668e7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/R/Estimator.R b/R/Estimator.R
@@ -587,7 +587,6 @@ doCrossValidationImpl <- function(dataset,
     fillEstimatorSettings(modelSettings$estimatorSettings,
                           fitParams,
                           parameters)
-  currentEstimatorSettings <- evalEstimatorSettings(currentEstimatorSettings)
   currentModelParams$catFeatures <- dataset$get_cat_features()$max()
   currentModelParams$numFeatures <- dataset$get_numerical_features()$len()
   if (currentEstimatorSettings$findLR) {

diff --git a/inst/python/Estimator.py b/inst/python/Estimator.py
@@ -42,7 +42,7 @@ def __init__(self, model, model_parameters, estimator_settings):
         self.batch_size = int(estimator_settings.get("batch_size", 1024))
         self.prefix = estimator_settings.get("prefix", self.model.name)
 
-        if estimator_settings["accumulation_steps"]:
+        if "accumulation_steps" in estimator_settings.keys() and estimator_settings["accumulation_steps"]:
             self.accumulation_steps = int(estimator_settings["accumulation_steps"])
             self.sub_batch_size = self.batch_size // self.accumulation_steps
         else: