On Snowflake always using QUOTED_IDENTIFIERS_IGNORE_CASE=TRUE to av…

…oid name mismatches when using quotes.
OHDSI · Sep 7, 2023 · 4278904 · 4278904
1 parent c2ae089
commit 4278904
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: DatabaseConnector
 Type: Package
 Title: Connecting to Various Database Platforms
-Version: 6.2.4
+Version: 6.3.0
 Date: 2023-09-07
 Authors@R: c(
  person("Martijn", "Schuemie", email = "[email protected]", role = c("aut", "cre")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,11 @@
+DatabaseConnector 6.3.0
+=======================
+
+Changes:
+
+1. On Snowflake always using `QUOTED_IDENTIFIERS_IGNORE_CASE=TRUE` to avoid name mismatches when using quotes.
+
+
 DatabaseConnector 6.2.4
 =======================
 

diff --git a/R/Connect.R b/R/Connect.R
@@ -709,7 +709,8 @@ connectSnowflake <- function(connectionDetails) {
  user = connectionDetails$user(),
  password = connectionDetails$password(),
  dbms = connectionDetails$dbms,
- "CLIENT_TIMESTAMP_TYPE_MAPPING"="TIMESTAMP_NTZ"
+ "CLIENT_TIMESTAMP_TYPE_MAPPING"="TIMESTAMP_NTZ",
+ "QUOTED_IDENTIFIERS_IGNORE_CASE"="TRUE"
  )
  }
  return(connection)

diff --git a/extras/TestOtherPlatforms.R b/extras/TestOtherPlatforms.R
@@ -68,11 +68,12 @@ scratchDatabaseSchemaDataBricks <- "scratch"
 connectionDetailsSnowflake <- createConnectionDetails(
  dbms = "snowflake",
  connectionString = keyring::key_get("snowflakeConnectionString"),
+ # connectionString = paste(keyring::key_get("snowflakeConnectionString"), "QUOTED_IDENTIFIERS_IGNORE_CASE=TRUE", sep="&"),
  user = keyring::key_get("snowflakeUser"),
  password = keyring::key_get("snowflakePassword")
 )
-cdmDatabaseSchemaSnowflake <- "ohdsi.eunomia"
-scratchDatabaseSchemaSnowflake <- "ohdsi.scratch"
+cdmDatabaseSchemaSnowflake <- "ATLAS.SYNPUF110K_CDM_53"
+scratchDatabaseSchemaSnowflake <- "ATLAS.RESULTS"
 
 # Open and close connection -----------------------------------------------
 
@@ -709,7 +710,11 @@ db <- DBI::dbConnect(odbc::odbc(),
 connection <- connect(connectionDetailsBigQuery)
 renderTranslateQuerySql(connection, "SELECT TOP 1 \"person_id\" FROM @schema.person;", schema = cdmDatabaseSchemaBigQuery)
 
-querySql(connection, "SELECT `person_id` FROM synpuf_2m.person LIMIT 1;")
+querySql(connection, "SELECT \"PERSON_ID\" FROM ATLAS.SYNPUF110K_CDM_53.person LIMIT 1;")
 
 disconnect(connection)
 
+
+connection <- connect(connectionDetailsSnowflake)
+renderTranslateQuerySql(connection, "SELECT TOP 1 \"person_id\" FROM @schema.person;", schema = cdmDatabaseSchemaSnowflake)
+disconnect(connection)