Fix get current surface for Android if use SDL #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paroj
reviewed
Sep 28, 2024
RenderSystems/GLSupport/src/EGL/Android/OgreAndroidEGLWindow.cpp
Outdated
Show resolved
Hide resolved
paroj
reviewed
Sep 28, 2024
RenderSystems/GLSupport/src/EGL/Android/OgreAndroidEGLWindow.cpp
Outdated
Show resolved
Hide resolved
|
one final request: please add the new property to the property table: ogre/OgreMain/include/OgreRenderSystem.h Line 395 in 185c369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On android, i'm using SDL for create window
But without this, app will be crash, because SDL already created surface, so just get the surface from current