-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin lookup to blob #34
Conversation
Nice! this looks good and will work I believe. However, I was thinking it would just be the admin 2 level data w/ all the columns we have here. No need to mix levels which i think might actually make it easier to get confused/make mistakes in the future. Also what is the purpose of the Pretty sure I can still get to the table I want w/ just simply doing:
but not sure if the mixing of levels is necessary? also tagging @isatotun so she is aware that there is a parquet file on the way for labelling the admin units on our hdx-floodscan pipeline |
@zackarno good point about there being some redundancy -- although we won't consistently go down to the admin-2 level for each ISO3 (eg. since some CODs don't have it, or we don't process non-HRP locations). I can simplify to just go down to the "max" admin level for each ISO3 (which we have specified in the |
ok gotcha - yeah I was thinking floodscan which is admin 2... What if we just add an Could then easily run something like
to get to the lowest level and clearly see what that is per country etc. |
yeah a good idea! Just added that in. |
it looks like it's all |
@zackarno where are you seeing it with everything |
sorry my mistake - i see admin 1 as well! Looks good to me - first test will be to see if we can slap labels on all the FloodScan data. Will check that out - so you can either merge and I will open an issue if necessary or leave open till this is tested |
Ok will merge and let me know if anything doesn't work for Floodscan! |
it looks good - no missing labels according to notebook which i just updated with this commit: f9b45b3 |
Great! I also just uploaded the same file to the |
A short-term solution to #30. This table is needed to unblock work in preparing Floodscan data for HDX. As discussed over Slack, more overall refactoring on the reference data before we put this in the database and fully productionalize. Data is output here, based on the cached Fieldmaps data in the same location.