Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_field_tooltip: Migration to 16.0 #2783

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

benwillig
Copy link
Contributor

No description provided.

@benwillig benwillig force-pushed the 16.0-mig-web_field_tooltip branch 2 times, most recently from ee2faec to 364f7f2 Compare March 26, 2024 08:06
@benwillig benwillig force-pushed the 16.0-mig-web_field_tooltip branch from 364f7f2 to e729006 Compare March 26, 2024 08:08
Copy link
Contributor

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, lgtm

Contributors
~~~~~~~~~~~~

* Benoit Aimont <[email protected]> (https://www.acsone.eu/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Benjamin Willig, innit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imbatman

@@ -0,0 +1 @@
* Benoit Aimont <[email protected]> (https://www.acsone.eu/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Benjamin Willig, innit?

@@ -0,0 +1 @@
* Find a way to update form views after tooltips update without refreshing manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but I dont think we should do something about it.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Apr 15, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2783-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fff0dcf into OCA:16.0 Apr 15, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 59c5e00. Thanks a lot for contributing to OCA. ❤️

@ThomasBinsfeld ThomasBinsfeld deleted the 16.0-mig-web_field_tooltip branch May 16, 2024 13:04
name = fields.Char(
compute="_compute_name",
readonly=True,
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @benwillig, I created this PR to follow up your change to re-declaring the field_name (since the field_name below was not deleted, causing your store=True change to seem to be overwritten). but I wonder why this change is made because when the field_name is not stored, the module still functions properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants