-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] web_field_tooltip: Migration to 16.0 #2783
Conversation
…ip on list views. One tooltip per field and do not handle user specific tooltips
…tip from the helper, splitted resources into multiple files
ee2faec
to
364f7f2
Compare
364f7f2
to
e729006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review, lgtm
Contributors | ||
~~~~~~~~~~~~ | ||
|
||
* Benoit Aimont <[email protected]> (https://www.acsone.eu/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Benjamin Willig, innit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1 @@ | |||
* Benoit Aimont <[email protected]> (https://www.acsone.eu/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And Benjamin Willig, innit?
@@ -0,0 +1 @@ | |||
* Find a way to update form views after tooltips update without refreshing manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but I dont think we should do something about it.
This PR has the |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 59c5e00. Thanks a lot for contributing to OCA. ❤️ |
name = fields.Char( | ||
compute="_compute_name", | ||
readonly=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @benwillig, I created this PR to follow up your change to re-declaring the field_name
(since the field_name
below was not deleted, causing your store=True
change to seem to be overwritten). but I wonder why this change is made because when the field_name
is not stored, the module still functions properly
No description provided.