[IMP][16.0] auth_saml: download the provider metadata #647
Conversation
|
Hi @vincent-hatakeyama, |
On Office365, what you get when configuring an application for SAML authentication is the URL of the federation metadata document. This URL is stable, but the content of the document is not. I suspect some of the encryption keys can be updated / renewed over time. The result is that the configured provider in Odoo suddenly stops working, because the messages sent by the Office365 provider can no longer be validated by Odoo (because the federation document is out of date). Downloading the new version and updating the auth.saml.provider record fixes the issue. This PR adds a new field to store the URL of the metadata document. When this field is set on a provider, you get a button next to it in the form view to download the document from the URL. The button will not update the document if it has not changed. Additionally, when a SignatureError happens, we check if downloading the document again fixes the issue.
Ricardoalso
force-pushed
the
auth_saml_metadata_16
branch
from
ce1e5d2
to
899db88
Compare
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-647-by-gurneyalex-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Migration to 16 of #602 feature