[17.0] [MIG] auth_ldaps: Migration to 17.0 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_ldaps/
|
/ocabot migration auth_ldaps |
acsonefho
approved these changes
May 24, 2024
|
|
||
| class CompanyLDAP(models.Model): | ||
| _inherit = "res.company.ldap" | ||
| _description = "Company LDAP configuration" |
There was a problem hiding this comment.
Agreed that it's better not to do this, but this was also present in 16.0, 15.0, etc.
Maybe it's better to fix it after upgrade with a "fix" PR, so the fix can be backported.
|
@rven I'm in the process of testing this at a client site - seems to be working well so far. Thanks for your efforts here! Do you have some time to solve the review changes? I would be happy to take over this PR if you're short on time. :) |
rven
force-pushed
the
17.0-mig-auth_ldaps
branch
from
12f7f8f
to
e8f06e7
Compare
|
@ryanc-me Changes implemented, also added a separate commit for the removal of the _description attribute. |
rven
force-pushed
the
17.0-mig-auth_ldaps
branch
from
e8f06e7
to
1337793
Compare
ryanc-me
approved these changes
Aug 5, 2024
nojusZeta
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.