[16.0][FIX] sale_discount_display_amount: Dedicated compute method for discounts #4092
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounts Because when the discount total is changed on a SOL, the discount total of every lines of the SO is recomputed. If we use the same method as the one that computes the price total, it triggers the recomputation of fields such as 'discount' and 'price_unit', which is unexpected.
qgroulard
force-pushed
the
16.0-sale_discount_display_amount_compute-qgr
branch
from
5413754 to
ee75280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because when the discount total is changed on a SOL, the discount total of every lines of the SO is recomputed.
If we use the same method as the one that computes the price total (
_compute_amount()), it triggers the re-computation of fields such as 'discount' and 'price_unit', which is unexpected.See in this video how price and discount of other lines are recomputed when we edit a line (before this patch):
Capture.video.du.07-01-26.14.50.06.webm