Skip to content

[18.0][IMP] purchase_partner_incoterm: set default incoterm when PO are created automatically #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronHForgeFlow wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+37 −0
Open

[18.0][IMP] purchase_partner_incoterm: set default incoterm when PO are created automatically #2907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions purchase_partner_incoterm/models/purchase_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,23 @@ def onchange_partner_id(self):
self.partner_id.commercial_partner_id.purchase_incoterm_address_id
)
return res

@api.model_create_multi
def create(self, vals_list):
for vals in vals_list:
if vals.get("partner_id"):
partner = (
self.env["res.partner"]
.browse(vals["partner_id"])
.commercial_partner_id
)
if "incoterm_id" not in vals and partner.purchase_incoterm_id:
vals["incoterm_id"] = partner.purchase_incoterm_id.id
if (
"incoterm_address_id" not in vals
and partner.purchase_incoterm_address_id
):
vals["incoterm_address_id"] = (
partner.purchase_incoterm_address_id.id
)
return super().create(vals_list)
17 changes: 17 additions & 0 deletions purchase_partner_incoterm/tests/test_purchase_partner_incoterm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,20 @@ def test_onchange_partner_id(self):
self.purchase_order.incoterm_address_id,
self.partner.purchase_incoterm_address_id,
)

def test_automated_po_creation(self):
auto_po = self.po_model.create({"partner_id": self.partner.id})
self.assertEqual(auto_po.incoterm_id, self.partner.purchase_incoterm_id)
self.assertEqual(
auto_po.incoterm_address_id, self.partner.purchase_incoterm_address_id
)

def test_user_override_preserved(self):
custom_incoterm = self.env.ref("account.incoterm_FCA")
po_with_custom = self.po_model.create(
{
"partner_id": self.partner.id,
"incoterm_id": custom_incoterm.id,
}
)
self.assertEqual(po_with_custom.incoterm_id, custom_incoterm)