-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] purchase_stock_price_unit_sync #2518
Open
ThiagoMForgeFlow
wants to merge
34
commits into
OCA:18.0
Choose a base branch
from
ForgeFlow:18.0-mig-purchase_stock_price_unit_sync
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] purchase_stock_price_unit_sync #2518
ThiagoMForgeFlow
wants to merge
34
commits into
OCA:18.0
from
ForgeFlow:18.0-mig-purchase_stock_price_unit_sync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k moves already done [UPD] Update purchase_stock_price_unit_sync.pot [UPD] README.rst
[UPD] Update purchase_stock_price_unit_sync.pot
[UPD] Update purchase_stock_price_unit_sync.pot
If we receive a kit, we shouldn't write the kit purchase price on the components price units. TT32040 purchase_stock_price_unit_sync 13.0.1.0.1
…nded costs for the update if the stock_landed_costs addon is installed. TT35009
Steps to reproduce: - Create a purchase order with an storable product and confirm it. - Validate the reception picking. - Create a landed cost linked to the reception picking and validate it. - Now change the unit price in the purchase order. Result: Both SVLs (stock valuation layers), the one for the reception, and the landed cost one, result overwritten with the new purchase unit price, while only the reception one should. As the landed cost SVL is put as children (through the field `stock_valuation_layer_id`), we filter out these ones from the write.
In purchase_discount the price_unit needs to be written in order to be able to compute the discount as the hook method isn't being used in core (for the moment). These write should be ignored as they'll lead to an infinite loop TT36816
…rors when accessing stock.valuation.layer TT45036
Currently translated at 100.0% (1 of 1 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_stock_price_unit_sync Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_stock_price_unit_sync/it/
…ck moves When the price of a line is changed, and it does not have any associated stock.move completed but does have stock.moves in a different state, this will result in no SVLs being found. Consequently, attempting to write to the empty recordset is causing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ForgeFlow