Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][WIP] purchase_service_picking: New module #2514

Draft
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

victoralmau
Copy link
Member

New module

Changes done:

  • Create picking when confirming purchase order + update purchase order lines
  • Immediate transfer option
  • Backorder option
  • Option cancel pickings
  • Option to return pickings
  • Update the quantity received on the purchase order line with the quantity done from the pickings
  • Tests
  • Documentation

@Tecnativa TT52524

@victoralmau victoralmau force-pushed the 14.0-add-purchase_service_picking branch from 879714c to 12880e9 Compare January 14, 2025 09:58
@victoralmau
Copy link
Member Author

Can you check it @pedrobaeza ?

@victoralmau victoralmau force-pushed the 14.0-add-purchase_service_picking branch 4 times, most recently from 7447fb0 to ebcac55 Compare January 15, 2025 07:54
@pedrobaeza pedrobaeza added this to the 14.0 milestone Jan 15, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test in runboat. Apart from the inline comments, check:

purchase_service_picking/models/service_picking.py Outdated Show resolved Hide resolved
purchase_service_picking/models/service_picking.py Outdated Show resolved Hide resolved
purchase_service_picking/models/service_picking.py Outdated Show resolved Hide resolved
purchase_service_picking/models/service_picking.py Outdated Show resolved Hide resolved
purchase_service_picking/models/service_picking.py Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 14.0-add-purchase_service_picking branch from ebcac55 to 7ea426a Compare January 15, 2025 09:57
@victoralmau
Copy link
Member Author

Code review and functional test in runboat. Apart from the inline comments, check:

* The icon for the service pickings smart-button being a truck may not be the most suitable, but I don't have right now a suggestion.

I have defined another icon that I think may be more useful.

* When you fill partial quantities, the initial demand field and the non filled lines are not adjusted the same as it happens on regular pickings. Please check both.

* I have decreased http://oca-purchase-workflow-14-0-pr2514-ebcac556754b.runboat.odoo-community.org/web#id=8&action=268&model=purchase.order&view_type=form&cids=&menu_id=168 (in the base DB) from 3 to 1, doing first a backorder of 2, and the result is that it's put -2 in the backorder instead of 0: http://oca-purchase-workflow-14-0-pr2514-ebcac556754b.runboat.odoo-community.org/web#id=2&action=280&active_id=8&model=service.picking&view_type=form&cids=&menu_id=168 (or the line removed - check how it's done on regular pickings in latest version -)

Both things are related and fixed.

Changes done.

@victoralmau victoralmau force-pushed the 14.0-add-purchase_service_picking branch from 7ea426a to 08ce1fd Compare January 15, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants