-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][WIP] purchase_service_picking: New module #2514
base: 14.0
Are you sure you want to change the base?
Conversation
879714c
to
12880e9
Compare
Can you check it @pedrobaeza ? |
7447fb0
to
ebcac55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and functional test in runboat. Apart from the inline comments, check:
- The icon for the service pickings smart-button being a truck may not be the most suitable, but I don't have right now a suggestion.
- When you fill partial quantities, the initial demand field and the non filled lines are not adjusted the same as it happens on regular pickings. Please check both.
- I have decreased http://oca-purchase-workflow-14-0-pr2514-ebcac556754b.runboat.odoo-community.org/web#id=8&action=268&model=purchase.order&view_type=form&cids=&menu_id=168 (in the base DB) from 3 to 1, doing first a backorder of 2, and the result is that it's put -2 in the backorder instead of 0: http://oca-purchase-workflow-14-0-pr2514-ebcac556754b.runboat.odoo-community.org/web#id=2&action=280&active_id=8&model=service.picking&view_type=form&cids=&menu_id=168 (or the line removed - check how it's done on regular pickings in latest version -)
ebcac55
to
7ea426a
Compare
I have defined another icon that I think may be more useful.
Both things are related and fixed. Changes done. |
7ea426a
to
08ce1fd
Compare
New module
Changes done:
@Tecnativa TT52524