[16.0][mig] project_deadline: Migration to 16.0 #1351

anusriNPS · 2024-10-16T11:19:02Z

Migrating project_deadline to 16.0

Reopened PR: #1123

anusriNPS · 2024-10-16T11:20:38Z

@heliaktiv , I have reopened PR of migrating project_deadline to 16.0 and I would request you to review it

PicchiSeba

Code review: LGTM

aleuffre · 2024-10-21T10:53:10Z

Please squash administrative commits, as described here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

aleuffre · 2024-10-21T10:56:53Z

project_deadline/tests/test_project_deadline.py

+        self.assertIn("date_start", res["arch"])
+        self.assertIn("date", res["arch"])


question: why were these two lines changed to be the opposite of what they were before?

As part of Odoo 16.0 addons project view, date_start and date fields are included in the xml whose external id is "edit_project" which is displayed as "Planned Date".

https://github.com/odoo/odoo/blob/16.0/addons/project/views/project_views.xml#L506C28-L511C119

As this is available as part of Odoo addons project module, I am removing project_project related code changes which appends date_start and date field to the form view from project_deadline module.
Also, the testcase related to it is also no longer valid for 16.0 version

anusriNPS · 2024-10-21T11:03:14Z

I tried to squash the commit, but it resulted in merge conflict issue related to project_hr commits, so could not do it.

When git rebase -i origin/16.0 is executed, it lists other project related repos like project_hr and showing merge conflicts related to hr project during squash

Is there any way to get only project_deadline related commits alone, so that it can be squashed?

aleuffre · 2024-10-21T12:01:05Z

I tried to squash the commit, but it resulted in merge conflict issue related to project_hr commits, so could not do it.

When git rebase -i origin/16.0 is executed, it lists other project related repos like project_hr and showing merge conflicts related to hr project during squash

Is there any way to get only project_deadline related commits alone, so that it can be squashed?

I suspect your repo may be outdated. Can you try git fetch origin 16.0 and then try to rebase again?

[FIX] Flake [ADD] Use fields_view_get [ADD] Use fields_view_get [ADD] Tests [FIX] Quick create form bug [ADD] usage description

Currently translated at 80.0% (4 of 5 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/

Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es_AR/

Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/it/

aleuffre

Code review, mostly looks good to me, only a couple of suggestions.

I also think the changes to the translation files should be removed from the migration commit.

aleuffre · 2024-11-06T12:06:06Z

project_deadline/views/project_project_view.xml

            <xpath expr="//span[@t-if='record.partner_id.value']" position="after">
                <t
-                    t-if="record.date.raw_value and record.date.raw_value lt (new Date())"
+                    t-if="record.date.raw_value and record.date.raw_value lt (new Date().toISOString())"
                    t-set="red"
                >oe_kanban_text_red</t>


suggestion (non-blocking): Instead of comparing two strings, we could turn record.date.raw_value into a Date object. See here for an example:

https://github.com/OCA/social/blob/16.0/mail_activity_board/views/mail_activity_view.xml#L186-L190

aleuffre · 2024-11-06T12:08:46Z

project_deadline/views/project_project_view.xml

+                <t t-if="record.partner_id.value">
+                    <span style="margin-left: 10px;" t-attf-class="#{red || ''}">
+                        <i>
+                            <field name="date" />
+                        </i>
+                    </span>
+                </t>
+                <t t-else="">
+                    <span t-attf-class="#{red || ''}">
+                        <i>
+                            <field name="date" />
+                        </i>
+                    </span>
+                </t>


issue(non-blocking): This could be done more elegantly without the t-if and t-else, maybe with a t-att-style?

aleuffre

Code review, ok.

However, upon functional review, I wonder if this module is worth migrating at all. Since we don't need to add the core fields that this module would offer, all we're adding is two related fields on project.task.

At the very least, the readme should be updated to reflect the much more limited scope of this module, but maybe the module can be dropped entirely.

aleuffre · 2024-11-08T08:56:39Z

project_deadline/views/project_project_view.xml

+<odoo>
+    <record id="view_project_kanban" model="ir.ui.view">
+        <field name="name">view_project_kanban</field>
+        <field name="model">project.project</field>
+        <field name="inherit_id" ref="project.view_project_kanban" />
+        <field name="arch" type="xml">
+            <xpath expr="//span[@t-if='record.partner_id.value']" position="after">
+                <t
+                    t-if="record.date.raw_value and ((new Date(record.date.raw_value)) lt (new Date()))"
+                    t-set="red"
+                >oe_kanban_text_red</t>
+                <span
+                    style="margin-left: 10px;"
+                    t-attf-class="{{ record.partner_id.value ? red : ''}}"
+                >
+                    <i>
+                        <field name="date" />
+                    </i>
+                </span>
+            </xpath>
+        </field>
+    </record>
+</odoo>


issue: Tested on runboat. We already have this info in the kanban.

(The date above is added by this module, the two dates below are in the base module)

Looking at the code, even the styling is the same. So we don't need this view at all.

Though I saw this information on the kanban view , since in 14.0 date was shown seperately near Partner_id I thought it should be shown in 16.0 even we have start and end date, hence added this.

Removed some of the code as those were not necessary in 16.0 however I misinterpreted this date information behaviour and added here

When project deadline is exceeded, in the base view date color is not changed to "Red" which is different from 14.0 view.

Suggestion: Instead of including new field which shows exceeded date in "Red", date already available can be shown in "Red" color.

Latest patchset:

When partner id is assigned, deadline surpassed will be indicated in "Red"

aleuffre

Code review, LGTM.

My doubts about whether this module is really useful remain, but I'll leave it up to a maintainer to decide.

anusriNPS changed the title ~~16.0 mig project deadline~~ [16.0][mig] project_deadline: Migration to 16.0 Oct 16, 2024

PicchiSeba approved these changes Oct 18, 2024

View reviewed changes

aleuffre reviewed Oct 21, 2024

View reviewed changes

tarteo and others added 7 commits October 21, 2024 16:06

[ADD] project_deadline

b33c9d8

[FIX] Flake [ADD] Use fields_view_get [ADD] Use fields_view_get [ADD] Tests [FIX] Quick create form bug [ADD] usage description

[UPD] Update project_deadline.pot

2733408

Added translation using Weblate (Croatian)

76367f6

Added translation using Weblate (Spanish)

7cf8bb9

Added translation using Weblate (Slovenian)

bc24a22

Added translation using Weblate (Italian)

018e292

pre-commit

9ada436

anusriNPS force-pushed the 16.0-mig-project_deadline branch from 133848f to d08d199 Compare October 21, 2024 14:27

oca-travis and others added 12 commits October 21, 2024 16:46

[UPD] Update project_deadline.pot

7c26a02

[MIG] project_deadline: Migration to 14.0

9883f48

Added translation using Weblate (Spanish (Argentina))

fab37ea

Added translation using Weblate (French (France))

f6f9dce

Added translation using Weblate (French)

a77c24b

Translated using Weblate (Spanish)

74f8909

Currently translated at 80.0% (4 of 5 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es/

Added translation using Weblate (Swedish)

10f0197

Added translation using Weblate (German)

8e213bb

Update translation files

93923a3

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/

Translated using Weblate (Spanish (Argentina))

a576177

Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/es_AR/

Translated using Weblate (Italian)

ee1733d

Currently translated at 100.0% (8 of 8 strings) Translation: project-14.0/project-14.0-project_deadline Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_deadline/it/

[IMP] project_deadline: black, isort, prettier

74a735b

anusriNPS force-pushed the 16.0-mig-project_deadline branch 2 times, most recently from b66b060 to a635b8a Compare October 22, 2024 15:31

aleuffre suggested changes Nov 6, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-project_deadline branch from a635b8a to 359d681 Compare November 7, 2024 13:01

aleuffre reviewed Nov 8, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-project_deadline branch 2 times, most recently from e38671f to af04c35 Compare November 8, 2024 10:25

[MIG] project_deadline: Migration to 16.0

743ccbb

anusriNPS force-pushed the 16.0-mig-project_deadline branch from af04c35 to 743ccbb Compare November 8, 2024 10:42

aleuffre approved these changes Nov 8, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][mig] project_deadline: Migration to 16.0 #1351

[16.0][mig] project_deadline: Migration to 16.0 #1351

anusriNPS commented Oct 16, 2024 •

edited

Loading

anusriNPS commented Oct 16, 2024

PicchiSeba left a comment

aleuffre commented Oct 21, 2024

aleuffre Oct 21, 2024

anusriNPS Oct 22, 2024

anusriNPS commented Oct 21, 2024

aleuffre commented Oct 21, 2024

aleuffre left a comment

aleuffre Nov 6, 2024

anusriNPS Nov 7, 2024

aleuffre Nov 6, 2024

anusriNPS Nov 7, 2024

aleuffre left a comment

aleuffre Nov 8, 2024

anusriNPS Nov 8, 2024

anusriNPS Nov 8, 2024

anusriNPS Nov 8, 2024

aleuffre left a comment

		self.assertIn("date_start", res["arch"])
		self.assertIn("date", res["arch"])

[16.0][mig] project_deadline: Migration to 16.0 #1351

Are you sure you want to change the base?

[16.0][mig] project_deadline: Migration to 16.0 #1351

Conversation

anusriNPS commented Oct 16, 2024 • edited Loading

anusriNPS commented Oct 16, 2024

PicchiSeba left a comment

Choose a reason for hiding this comment

aleuffre commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusriNPS commented Oct 21, 2024

aleuffre commented Oct 21, 2024

aleuffre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleuffre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleuffre left a comment

Choose a reason for hiding this comment

anusriNPS commented Oct 16, 2024 •

edited

Loading