Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] project_forecast_line #1247

Open
wants to merge 75 commits into
base: 16.0
Choose a base branch
from

Conversation

ntsirintanis
Copy link

No description provided.

Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your fixup commits

@ntsirintanis ntsirintanis force-pushed the 16.0-mig-project_forecast_line branch from 7ffa1c0 to a5080b7 Compare April 29, 2024 07:13
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@gjotten
Copy link

gjotten commented Sep 4, 2024

@OCA/project-service-maintainers this needs a no-stale

Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
yankinmax and others added 18 commits October 24, 2024 09:03
in some cases, we could have capacity consumed by a task which was not matching
a work capacity line in the period because of a faulty optimisation we were making
which skipped the creation of lines with a capacity of 0 -> then we had no line on which
to compute the negative consolidated capacity.

We remove the optimisation to fix this case and show the problematic periods
in the consolidated capacity graphs
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
During some operations, forecast lines are deleted and recreated. This
can lead to some hr.employee.forecast.role lines being deleted which
leaves the forecast lines on the same period without a related document
to store the consolidated capacity. Normally that line is recreated
shortly afterwards but the creation does not recompute the link between
the parent-less lines and the new one. This patches forces the
recomputation when new lines are created.
gurneyalex and others added 29 commits October 24, 2024 09:03
use ondelete='cascade' to handle the unlinking of forecast.line records
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
Fix an issue in project_forecast_line where lines would be removed by
the cron.

When an employee has a forecast role with an end date set, depending on
the order of the processing of records in the cron, a bug could remove
forecast lines of other employees when attempting to remove the forecast
lines related to thatrole which had been generated after the end date in
previous runs (before the end date was set).

Fix this by using the correct domain.
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
when running in multi company, sometimes the user making a change is not connected
using the company of the record. In this case the default value for company_id on
forecast.line will lead to a wrong forecast.

we fix this by using the best company when updating the forecast (the
employee's company for task assigned to employees or leaves, the sale
line's company for sales forecast
the condition was wrong, preventing the fast update from being used
when only the remaining time is updated
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
when using the quick update, we would get an inversion of the sign of the forecast
because the ratio was negative
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Currently translated at 100.0% (95 of 95 strings)

Translation: project-15.0/project-15.0-project_forecast_line
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_forecast_line/it/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.