Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mgmtsystem_nonconformity_hazard: Migration to 18.0 #626

Merged

Conversation

HeliconiaSolutions
Copy link
Contributor

@HeliconiaSolutions HeliconiaSolutions commented Jan 20, 2025

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration mgmtsystem_nonconformity_hazard

@@ -16,7 +16,7 @@
<page string="Hazards" name="hazards">
<field
name="hazard_ids"
attrs="{'readonly':[('state','not in',['draft','analysis'])]}"
readonly="[('state','not in',['draft','analysis'])]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This domain expression should be transformed to a pythonic expression.

readonly="state not in ('draft', 'analysis')"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivantodorovich, Thanks for the suggestion! it's fixed.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 20, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 20, 2025
28 tasks
@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-mgmtsystem_nonconformity_hazard branch from 18fe122 to df91313 Compare January 21, 2025 05:31
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-626-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3403736 into OCA:18.0 Jan 22, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e6a826. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants