[FIX]hr_employee_calendar_planning:incorrect hours_per_day #1436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always using the topmost hr.employee.calendar for hours_per_day may lead to unexpected and incorrect behavior. For example if the date_start and date_end of the topmost calendar are in the future. Then the hours_per_day from the future calendar are taken not from the currently used one. The more specific calendars in regard of date_start and date_end are considered earlier than the less specific ones.
Additionally, added a scheduled action to keep hours_per_day up to date.
How to recreate the problem:
The hours_per_day are set to the value of the topmost resource.calendar. That calendar should not be used currently. This can lead to incorrect behavior. For example for incorrect calculations of time offs.