[17.0][ADD] hr_recruitment_stage_active
#1399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankinmax
force-pushed
the
add-hr_recruitment_stage_active
branch
3 times, most recently
from
c90cc47 to
cfc53d8
Compare
yankinmax
force-pushed
the
add-hr_recruitment_stage_active
branch
from
cfc53d8 to
56b6e52
Compare
gurneyalex
approved these changes
Dec 2, 2024
yankinmax
force-pushed
the
add-hr_recruitment_stage_active
branch
from
56b6e52 to
18fcaac
Compare
vvrossem
approved these changes
Dec 2, 2024
dreispt
approved these changes
Dec 10, 2024
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 10, 2024
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1399-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
vvrossem
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Hello @yankinmax, could you please check the CI error?
2024-12-02 09:56:22,097 233 CRITICAL odoo odoo.service.server: Failed to initialize database `odoo`.
Traceback (most recent call last):
File "/opt/odoo/odoo/service/server.py", line 1313, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "<decorator-gen-16>", line 2, in new
File "/opt/odoo/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/opt/odoo/odoo/modules/registry.py", line 114, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/opt/odoo/odoo/modules/loading.py", line 480, in load_modules
processed_modules += load_marked_modules(env, graph,
File "/opt/odoo/odoo/modules/loading.py", line 364, in load_marked_modules
loaded, processed = load_module_graph(
File "/opt/odoo/odoo/modules/loading.py", line 227, in load_module_graph
load_data(env, idref, mode, kind='data', package=package)
File "/opt/odoo/odoo/modules/loading.py", line 71, in load_data
tools.convert_file(env, package.name, filename, idref, mode, noupdate, kind)
File "/opt/odoo/odoo/tools/convert.py", line 627, in convert_file
convert_xml_import(env, module, fp, idref, mode, noupdate)
File "/opt/odoo/odoo/tools/convert.py", line 693, in convert_xml_import
obj.parse(doc.getroot())
File "/opt/odoo/odoo/tools/convert.py", line 613, in parse
self._tag_root(de)
File "/opt/odoo/odoo/tools/convert.py", line 556, in _tag_root
f(rec)
File "/opt/odoo/odoo/tools/convert.py", line 567, in _tag_root
raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
odoo.tools.convert.ParseError: while parsing /opt/odoo/addons/hr_recruitment/views/hr_applicant_views.xml:442
Invalid model name 'sms.composer' in action definition.
View error context:
'-no context-'
| active = fields.Boolean( | ||
| help="The active field allows you to hide the stage without removing it.", | ||
| default=True, | ||
| tracking=True, |
There was a problem hiding this comment.
odoo.fields: Field hr.recruitment.stage.active: unknown parameter 'tracking', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
Should tracking be removed?
Or should the following method be added?
def _valid_field_parameter(self, field, name):
return name == 'tracking' or super()._valid_field_parameter(field, name)
There was a problem hiding this comment.
IMO it should be removed.
tracking makes sense only on records that inherit mail.thread, and this one doesn't --> hence the warning
ivantodorovich
suggested changes
Jan 28, 2025
on it right now |
yankinmax
force-pushed
the
add-hr_recruitment_stage_active
branch
from
18fcaac to
315d8dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.