GraalVM (WIP, broken) #434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewit
added a commit
to edewit/minecraft-storeys-maker
that referenced
this pull request
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#295 related WIP
It doesn't work yet as-is; the 1st commit fails because that pulls GraalVM JARs which require higher version than Java 8,
and the 2nd commit which adds 4x binary JARs for Java 8 has some other issues (incl. how to have johnrengelman's
shadowplugin package those JARs from thefilesdependency; once other problems with it are solved).So we concluded that IFF we manage to (separately, first) do #433 then we can cherry pick (only) the 1st commit of this, and it should work.
@edewit