Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visible tabs #266

Open
wants to merge 3 commits into
base: v3.0
Choose a base branch
from
Open

Conversation

romanschulz
Copy link
Contributor

@romanschulz romanschulz commented Mar 27, 2024

Now all the space is not used enough. The total length of one tab is 21 characters, therefore it is necessary to adjust the calculation of which tabs can be displayed and which ones cannot. Also modify the padding calculation for a tab length of 21 characters.

@lucario387
Copy link
Collaborator

Can we also put that magic number 21 to the top of that file (or somewhere else), then use it?
This doesn't seem maintainable

@romanschulz
Copy link
Contributor Author

of course, I created a local constant BUF_WIDTH, which I use in both places

@lucario387 lucario387 requested a review from siduck March 27, 2024 10:38
@siduck
Copy link
Member

siduck commented Mar 27, 2024

the total length of a tab was 23 before, why 21?

@siduck
Copy link
Member

siduck commented Mar 27, 2024

😨

@lucario387
Copy link
Collaborator

why are we closing this @romanschulz

You can change it back

@siduck siduck reopened this Mar 27, 2024
@romanschulz
Copy link
Contributor Author

I tried to determine the exact width of the panel for the buffer, because I think it is little bit smaller than the mentioned 23 characters, I just don't know if it is always... sometimes I counted 21 and now I saw that it can be 22 characters. When I think about it, it is the sum of: space + icon + space + 15 characters of the filename (or 16?) + space + X button + space = 21 (or 22)

image

@siduck
Copy link
Member

siduck commented Jun 9, 2024

@romanschulz pr looks right, just lowecase the variable buf_width

@siduck siduck force-pushed the v3.0 branch 2 times, most recently from 8b670b9 to 5be808e Compare October 29, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants