-
Notifications
You must be signed in to change notification settings - Fork 6
Store linear invariants matrix in (Conservative)PDSProblem #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ranocha
merged 13 commits into
NumericalMathematics:main
from
jmbender:jb/linearInvariants
May 30, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
04e6a01
added lin invariants in PDSFunction and ConservativePDSFunction
jmbender 36166f6
added linear Invariants for linmod test problem, typo
jmbender 485e354
add lin invariants to problem library
jmbender 925588c
renamed lin_invariants to linear_invariants, corrected minmapk linear…
jmbender 253b7a8
add tests for linear invariant matrices
jmbender 96c7db2
typo
jmbender e2a499e
add @SMatrix, typo
jmbender 122f119
Merge branch 'jb/linearInvariants' of https://github.com/jmbender/Pos…
jmbender 1bd2bbc
format
jmbender 09a77b5
fix stefan
jmbender 5448b63
requested changes hendrik 'runtests'
jmbender b8bedff
described 'linear invariants' in docstring
jmbender fdb86a5
revised docstring
jmbender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
linear_invariantsis a new feature, it should be documented at least in the docstring above. You can mention, for now, that it is an experimental feature so that we may change its behavior without having to release a breaking version of PositiveIntegrators.jl. If you do so, could you please also open an issue allowing us to track the status of this experimental feature?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linear_invariantsneeds to be added at the beginning of the docstring as well.In addition,
linear_invariantsneeds to be mentioned in the docstring ofConservativePDSProblem.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me why the introduction of
linear_invariantscould be breaking. It's an optional feature and every code that ran in the past will also run in the future. Is it breaking because thePDSFunctionandConservativePDSFunctionstructs changed? But these structs are only used internally and are not documented.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Hendrik means is not that adding this feature is breaking, but rather that in the future it might be necessary or desirable to change this feature again (e.g. changing the API), which could break code then. Adding a note that this is experimental, allows us to do that without the need to care too much about creating a breaking release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done