Skip to content

Conversation

@JoshuaLampert
Copy link
Member

This implements the second point from #263.

@JoshuaLampert JoshuaLampert mentioned this pull request Dec 16, 2025
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main f7c7582... main / f7c7582...
bbm_1d/bbm_1d_basic.jl - rhs!: 12.7 ± 1.6 μs 12.8 ± 1.5 μs 0.997 ± 0.17
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.256 ± 0.0063 ms 0.245 ± 0.0066 ms 1.04 ± 0.038
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0746 ± 0.007 ms 0.0764 ± 0.01 ms 0.977 ± 0.16
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0325 ± 0.00055 ms 0.0321 ± 0.00057 ms 1.01 ± 0.025
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 24.8 ± 2.7 μs 25.2 ± 2.5 μs 0.982 ± 0.15
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0317 ± 0.0032 ms 0.032 ± 0.003 ms 0.99 ± 0.14
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 5.69 ± 0.7 μs 5.88 ± 0.54 μs 0.967 ± 0.15
kdv_1d/kdv_1d_basic.jl - rhs!: 1.75 ± 0.072 μs 2.13 ± 0.24 μs 0.822 ± 0.098
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.9 ± 0.22 μs 1.79 ± 0.16 μs 1.06 ± 0.16
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.211 ± 0.021 ms 0.213 ± 0.021 ms 0.993 ± 0.14
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.157 ± 0.016 ms 0.157 ± 0.016 ms 1 ± 0.14
time_to_load 1.9 ± 0.0011 s 1.91 ± 0.0067 s 0.992 ± 0.0035
Memory benchmarks
main f7c7582... main / f7c7582...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 20282827165

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 98.475%

Totals Coverage Status
Change from base Build 20281879153: 0.008%
Covered Lines: 2325
Relevant Lines: 2361

💛 - Coveralls

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit c2f2d2e into main Dec 17, 2025
13 checks passed
@JoshuaLampert JoshuaLampert deleted the plot-analytical branch December 17, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants