Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade MSBuild to .NET SDK's supported version #6015

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Sep 6, 2024

this is for release-6.11.x, which maps to .NET 8.0.4xx SDK

Bug

Fixes: NuGet/Home#13775

Description

The .NET SDK has documented the minimum VS that the SDK supports. NuGet cannot use versions of MSBuild higher than that, otherwise it will unintentionally break the .NET SDK on older versions of VS
https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#targeting-and-support-rules

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests manually tested, will think about some kind of validation in the dev branch to try to enforce it.
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan marked this pull request as ready for review September 7, 2024 00:33
@zivkan zivkan requested a review from a team as a code owner September 7, 2024 00:33
@zivkan zivkan merged commit 5469bd0 into release-6.11.x Sep 9, 2024
26 of 28 checks passed
@zivkan zivkan deleted the dev-zivkan-6.11-downgrade-msbuild branch September 9, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants