Workflow #11
Open
Workflow #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 test cases as described in the assignment. Failed first on test case 2, updated inputHref and all tests now pass 🥳
2 test cases completed. Also added ...globals.node to eslint.config
Adding scripts to package.json and default defineConfig to playwright.config.js. I get 6 vulnerabilities (2 moderate, 4 high) and I'm not able to solve them with npm audit fix, or by manually upgrading the problematic packages
3 test cases: login successful, login failed wrong password, login failed wrong email. Struggling a bit with the tests due to timeout error
4 steps
Adding [email protected] since email must contain this
Updating some styling
Adding ``` bash markdown formatting for the terminal
Adding section about contribution
Final changes README. Updated unit and e2e terminal commands to match package.json
forgot to add "unit"
Added automatically when playwright was intalled. This test fails, so removed it
So that example match the actual variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This PR merges changes from the workflow branch into the main branch, which includes the following updates:
Workflow Setup: Configured ESLint, Prettier, and Vitest for linting, formatting, and unit testing, ensuring code quality and consistency.
Testing: Set up Playwright for end-to-end testing and Vitest for unit testing, ensuring thorough test coverage for both development and production environments.
Scripts: Added various NPM scripts for easy development workflow:
npm run start: Launches the development server with Live Server.npm run test:unit: Runs unit tests with Vitest.npm run test:e2e: Executes Playwright end-to-end tests.npx eslint and npx prettier . --write: Automatically lints and formats the code.Environment Setup: Included configuration for environment variables required for testing and development.
This PR also updates the README.md with clear instructions on how to install dependencies, run tests, and use the various scripts for development and testing.