Update wasm-tools so that we can use latest wit-parser #13
+529
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transitive deps to align
…sed on breaking dep changes.
…ush` so that slang's `infra ci` command succeeds. There's no guarantee that this is the intended implementation of this instruction. However, I've check the generated js output for slang and didn't notice any weird output.
OmarTawfik
reviewed
Feb 4, 2025
| @@ -2,18 +2,6 @@ | |||
| # It is not intended for manual editing. | |||
| version = 3 | |||
There was a problem hiding this comment.
with one small exception that will be handled in slang itself
was this the ComponentError commit we added here?
is there anything else missing?
OmarTawfik
reviewed
Feb 4, 2025
OmarTawfik
reviewed
Feb 4, 2025
OmarTawfik
requested changes
Feb 4, 2025
OmarTawfik
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes for whitespace in doc comments got merged into the head of
wasm-tools, as you'd expect, butjcois a few versions behind. This PR updates the dependencies forwasm-toolsand a few other necessary ones so that we can utilize thewit-parserfix.In newer versions of
wit-bindgenthey've added new instructions for handling lowering async and futures. These changes haven't been implemented in bytecodealliance/jco yet, so where required those instructions have been stubbed out here. The only exception isInstruction::Flushinfunction_bindgen.rs. That instruction is being emitted when generating code for slang, so some kind of "real" implementation needed to be added. I went with the most minimal implementation I could come up with. I have no guarantee that this is how they intend this instruction to be handled, but I've tested it withinfra ciand everything works (with one small exception that will be handled in slang itself).