Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.9.0 #89

Merged
merged 32 commits into from
Dec 5, 2021
Merged

V0.9.0 #89

merged 32 commits into from
Dec 5, 2021

Conversation

fraxken
Copy link
Member

@fraxken fraxken commented Oct 9, 2021

Hello 👋

Opening a (Draft) pull request for the next version of the tool. This version use the new NodeSecure back-end (Many codes and logic are no longer present in this project). It require Node.js v16.

I took the opportunity to heavily improve the CLI code (see src/commands).

What remains to be done:

  • Emoji description in the UI are not ok (because of our HTML format in NodeSecure/flags). @Kawacrepe
  • There is colors issues in the verify and summary commands (not sure why some colors are not working.. in my terminal at least). @tony-go
  • Some tests are missing

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #89 (bbe1c8b) into master (cb38008) will decrease coverage by 71.89%.
The diff coverage is 16.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
- Coverage   87.94%   16.04%   -71.90%     
===========================================
  Files           8        8               
  Lines         614      243      -371     
  Branches      108       45       -63     
===========================================
- Hits          540       39      -501     
- Misses         62      177      +115     
- Partials       12       27       +15     
Impacted Files Coverage Δ
src/commands/http.js 0.00% <0.00%> (ø)
src/commands/lang.js 0.00% <0.00%> (ø)
src/commands/scanner.js 0.00% <0.00%> (ø)
src/commands/summary.js 0.00% <0.00%> (ø)
src/commands/verify.js 0.00% <0.00%> (ø)
src/commands/vulnerability.js 0.00% <0.00%> (ø)
src/httpServer.js 90.32% <90.32%> (-9.68%) ⬇️
src/utils.js 100.00% <100.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0c536...bbe1c8b. Read the comment docs.

@tony-go
Copy link
Member

tony-go commented Oct 10, 2021

👏 Nice job!

I'll try to take a look this week.

@Kawacrepe
Copy link
Member

Hey !

I just submited a PR which fix the flags problem.

Here is a preview image

@fraxken
Copy link
Member Author

fraxken commented Oct 30, 2021

Opened an issue on CLIUI for colors issues on summary/verify command: yargs/cliui#113

@fraxken
Copy link
Member Author

fraxken commented Nov 11, 2021

Note: need to use the http server to request bundlephobia (because CORS).

tony-go and others added 5 commits November 26, 2021 21:10
* chore(http): use http-server folder

* chore(http): move root route

* test(http): add first test

* chore: add updated package.json

* chore(http): finish root tests

* chore: create context (AsyncLocalStorage)

* feat(http): split data endpoint

* chore(http): port middleware in split file

* chore(http): remove useless spec test

* chore(http): fix naming for root import

* chore(http): add flags

* revert: remove sinon deps

* chore: add missing import comment
* feat: add new routes and handle error

* fix: pass httpie error to polka

* feat: replace request

* fix: delete forgotten console.log

* revert: port context
@fraxken fraxken marked this pull request as ready for review December 5, 2021 15:11
@fraxken fraxken merged commit 25c0b1b into master Dec 5, 2021
@fraxken fraxken deleted the v0.9.0 branch December 5, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants