Skip to content

🎨 Palette: Improve accessibility for password visibility toggles#1366

Open
tinkle-community wants to merge 1 commit intodevfrom
palette-password-toggle-a11y-1470963664968926670
Open

🎨 Palette: Improve accessibility for password visibility toggles#1366
tinkle-community wants to merge 1 commit intodevfrom
palette-password-toggle-a11y-1470963664968926670

Conversation

@tinkle-community
Copy link
Collaborator

@tinkle-community tinkle-community commented Jan 29, 2026

Pull Request - Frontend

💡 Tip: Recommended PR title format type(scope): description
Example: feat(ui): add dark mode toggle | fix(form): resolve validation bug


📝 Description


🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🎨 Code style update
  • ♻️ Refactoring
  • ⚡ Performance improvement

🔗 Related Issues

  • Closes #
  • Related to #

📋 Changes Made


📸 Screenshots / Demo

Before:

After:


🧪 Testing

Test Environment

  • OS:
  • Node Version:
  • Browser(s):

Manual Testing

  • Tested in development mode
  • Tested production build
  • Tested on multiple browsers
  • Tested responsive design
  • Verified no existing functionality broke

🌐 Internationalization

  • All user-facing text supports i18n
  • Both English and Chinese versions provided
  • N/A

✅ Checklist

Code Quality

  • Code follows project style
  • Self-review completed
  • Comments added for complex logic
  • Code builds successfully (npm run build)
  • Ran npm run lint
  • No console errors or warnings

Testing

  • Component tests added/updated
  • Tests pass locally

Documentation

  • Updated relevant documentation
  • Updated type definitions (TypeScript)
  • Added JSDoc comments where necessary

Git

  • Commits follow conventional format
  • Rebased on latest dev branch
  • No merge conflicts

📚 Additional Notes


By submitting this PR, I confirm:


🌟 Thank you for your contribution!

- Added `aria-label` and `aria-pressed` to password visibility toggle buttons in Login, Register, and Reset Password pages.
- Added missing `showPassword` and `hidePassword` translations in English and Chinese.
- This ensures screen reader users can understand and interact with the password toggle functionality.

Co-authored-by: tinkle-community <240652709+tinkle-community@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

⚠️ PR Title Format Suggestion

Your PR title doesn't follow the Conventional Commits format, but this won't block your PR from being merged.

Current title: 🎨 Palette: Improve accessibility for password visibility toggles

Recommended format: type(scope): description

Valid types:

feat, fix, docs, style, refactor, perf, test, chore, ci, security, build

Common scopes (optional):

exchange, trader, ai, api, ui, frontend, backend, security, deps, workflow, github, actions, config, docker, build, release

Examples:

  • feat(trader): add new trading strategy
  • fix(api): resolve authentication issue
  • docs: update README
  • chore(deps): update dependencies
  • ci(workflow): improve GitHub Actions

Note: This is a suggestion to improve consistency. Your PR can still be reviewed and merged.


This is an automated comment. You can update the PR title anytime.

@cla-assistant
Copy link

cla-assistant bot commented Jan 29, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Jan 29, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

🎨 已自动应用专用模板 | Auto-Applied Template

检测到您的PR主要包含 frontend 相关的变更,系统已自动为您应用相应的模板。

Detected that your PR primarily contains frontend changes. The appropriate template has been automatically applied.

文件统计 | File Statistics

  • 🎨 TypeScript files: 4
  • 📝 Markdown files: 1

已应用模板 | Applied Template
.github/PULL_REQUEST_TEMPLATE/frontend.md

✨ 您现在可以直接在PR描述中填写相关信息了!

✨ You can now fill in the relevant information in the PR description!

@github-actions
Copy link

🤖 Advisory Check Results

These are advisory checks to help improve code quality. They won't block your PR from being merged.

📋 PR Information

Title Format: ⚠️ Suggestion - Consider using type(scope): description

Recommended format

Valid types: feat, fix, docs, style, refactor, perf, test, chore, ci, security, build

Examples:

  • feat(trader): add new trading strategy
  • fix(api): resolve authentication issue
  • docs: update README

PR Size: 🟢 Small (37 lines: +37 -0)

🔧 Backend Checks

Go Formatting: ⚠️ Needs formatting

Files needing formatting
api/strategy.go
api/utils_test.go
backtest/aicache.go
backtest/config.go
backtest/types.go
debate/engine.go
experience/experience.go
kernel/engine.go
kernel/formatter.go
kernel/grid_engine.go

Go Vet: ✅ Good
Tests: ✅ Passed

Fix locally:

go fmt ./...      # Format code
go vet ./...      # Check for issues
go test ./...     # Run tests

⚛️ Frontend Checks

Build & Type Check: ✅ Success

Fix locally:

cd web
npm run build  # Test build (includes type checking)

📖 Resources

Questions? Feel free to ask in the comments! 🙏


These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml.

@github-actions
Copy link

🐳 Docker Build Check Results

AMD64 builds: ✅ success
ARM64 build (native runner): ✅ success

🎉 All Docker builds passed!

✨ Using GitHub native ARM64 runners - 3x faster than emulation!

After merge, full multi-arch builds will run in ~10-12 minutes.

Checked: Backend (amd64 + arm64 native), Frontend (amd64) | Powered by GitHub ARM64 Runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant