🎨 Palette: Improve accessibility for password visibility toggles#1366
🎨 Palette: Improve accessibility for password visibility toggles#1366tinkle-community wants to merge 1 commit intodevfrom
Conversation
- Added `aria-label` and `aria-pressed` to password visibility toggle buttons in Login, Register, and Reset Password pages. - Added missing `showPassword` and `hidePassword` translations in English and Chinese. - This ensures screen reader users can understand and interact with the password toggle functionality. Co-authored-by: tinkle-community <240652709+tinkle-community@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
|
1 similar comment
|
|
🎨 已自动应用专用模板 | Auto-Applied Template检测到您的PR主要包含 frontend 相关的变更,系统已自动为您应用相应的模板。 Detected that your PR primarily contains frontend changes. The appropriate template has been automatically applied. 文件统计 | File Statistics
已应用模板 | Applied Template ✨ 您现在可以直接在PR描述中填写相关信息了! ✨ You can now fill in the relevant information in the PR description! |
🤖 Advisory Check ResultsThese are advisory checks to help improve code quality. They won't block your PR from being merged. 📋 PR InformationTitle Format: Recommended formatValid types: Examples:
PR Size: 🟢 Small (37 lines: +37 -0) 🔧 Backend ChecksGo Formatting: Files needing formattingGo Vet: ✅ Good Fix locally: go fmt ./... # Format code
go vet ./... # Check for issues
go test ./... # Run tests⚛️ Frontend ChecksBuild & Type Check: ✅ Success Fix locally: cd web
npm run build # Test build (includes type checking)📖 ResourcesQuestions? Feel free to ask in the comments! 🙏 These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml. |
🐳 Docker Build Check ResultsAMD64 builds: ✅ success 🎉 All Docker builds passed!✨ Using GitHub native ARM64 runners - 3x faster than emulation! After merge, full multi-arch builds will run in ~10-12 minutes. Checked: Backend (amd64 + arm64 native), Frontend (amd64) | Powered by GitHub ARM64 Runners |
Pull Request - Frontend
📝 Description
🎯 Type of Change
🔗 Related Issues
📋 Changes Made
📸 Screenshots / Demo
Before:
After:
🧪 Testing
Test Environment
Manual Testing
🌐 Internationalization
✅ Checklist
Code Quality
npm run build)npm run lintTesting
Documentation
Git
devbranch📚 Additional Notes
By submitting this PR, I confirm:
🌟 Thank you for your contribution!